Editor: Fix initial edits applied again after saving the post #68273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
Mamaduka
reviewed
Dec 24, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -8 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 98e8a2b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12482428622
|
ramonjd
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in https://github.com/WordPress/gutenberg/pull/62304/files#r1896745958
Basically the "setupEditor" action is only meant to run once and the addition of the extra dependencies (I'm assuming it was done to please the linter) caused the "initial edits" to be applied again if a post was loaded with initial edits and was saved again.
I think this hook can be rewritten in a different way but for now, I think it's better to just revert to the previous behavior.
Testing Instructions
1- Install Jetpack and enable the "Copy post" writing feature
2- Open the post list
3- Click "copy post"
4- Edit the copied post title
5- Hit save
6- The post title shouldn't revert to the original title and the modified title should be kept.