Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Update Settings text labels #68265

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Button: Update Settings text labels #68265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3921211
Button: Update Settings text labels
Mamaduka Dec 24, 2024
43faddb
Update e2e test
Mamaduka Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-library/src/button/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,14 @@ function WidthPanel( { selectedWidth, setAttributes } ) {
dropdownMenuProps={ dropdownMenuProps }
>
<ToolsPanelItem
label={ __( 'Button width' ) }
label={ __( 'Width' ) }
isShownByDefault
hasValue={ () => !! selectedWidth }
onDeselect={ () => setAttributes( { width: undefined } ) }
__nextHasNoMarginBottom
>
<ToggleGroupControl
label={ __( 'Button width' ) }
label={ __( 'Width' ) }
value={ selectedWidth }
onChange={ ( newWidth ) =>
setAttributes( { width: newWidth } )
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/specs/editor/blocks/buttons.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ test.describe( 'Buttons', () => {
.getByRole( 'tab', { name: 'Settings' } )
.click();
await page
.getByRole( 'radiogroup', { name: 'Button width' } )
.getByRole( 'radiogroup', { name: 'Width' } )
.getByRole( 'radio', { name: '25%' } )
.click();

Expand Down
Loading