Remove isolated template editing actions in write mode #68258
+63
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
jasmussen,
richtabor,
annezazu and
jameskoster
6 tasks
|
Size Change: +133 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d1d7d62. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12478052813
|
talldan
changed the title
jasmussen
approved these changes
Dec 25, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follows up on #67372, in particular @annezazu's comments about:
Why?
The general idea is that Write Mode is kept very simple, and access to those more advanced options isn't available without switching out of Write Mode.
I think it needs some wider feedback though, as it didn't seem like there was consensus in #67372
How?
Adds a few conditions to the rendering of these elements
Testing Instructions
Double click behavior
Edit button on synced patterns and template parts
Screenshots or screencast