Scripts: Recommend passing JS entry points with paths #68251
+160
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Status] In Progress
gziolo
commented
Dec 23, 2024
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 410bba4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12471391077
|
7 tasks
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
approved these changes
Dec 26, 2024
| - `--webpack-no-externals` – disables scripts' assets generation, and omits the list of default externals. | ||
| - `--webpack-src-dir` – Allows customization of the source code directory. Default is `src`. | ||
| - `--webpack-no-externals` – disables scripts’ assets generation, and omits the list of default externals. | ||
| - `--source-path` – Allows customization of the source directory. Default is `.`. In the automatic detection mode the default changes to `src`. |
There was a problem hiding this comment.
What does "automatic detection mode" mean? I see there's another section on ### Automatic block.json detection and the source code directory - it would be good to link to that. That can be in a follow-up so we know what the link is.
| - `--webpack-no-externals` – disables scripts' assets generation, and omits the list of default externals. | ||
| - `--webpack-src-dir` – Allows customization of the source code directory. Default is `src`. | ||
| - `--webpack-no-externals` – disables scripts’ assets generation, and omits the list of default externals. | ||
| - `--source-path` – Allows customization of the source directory. Default is `.`. In the automatic detection mode the default changes to `src`. |
There was a problem hiding this comment.
Same question about the "automatic detection mode."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improves listing entry points in the build commands:
buildandstartfrom the@wordpress/scriptspackage. Using explicit entry points in the command becomes the recommended way to build the project that contains JavaScript code for UI plugins extending the editor in WordPress core.Why?
Today,
@wordpress/create-blockis too optimized for the specific use case of developing a single block as a WordPress plugin. Things quickly get more complicated when a custom JavaScript is integrated to extend the block editor. In particular, extending the default webpack config included with@wordpress/scriptsis way too complex. This is an attempt to address it by promoting an improved strategy for handling multiple JacaScript files as entry points.How?
Testing Instructions