-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duotone and dimensions to the block level for translation #68243
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
e6a7212
to
f4d8ef2
Compare
@oandregal I wonder, how can we prevent this (forgetting to make these strings translatable) from happening in the future? A CI workflow or lint script would be useful IMO. |
Flaky tests detected in f4d8ef2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12466419429
|
Yeah, judging by the number of misses, I agree this is an area that needs to raise more awareness. I'm happy to help with this, but I'm not sure how the lint would work, though. There are heuristics, but they are a bit weak: arrays present in |
Or maybe just some bot telling you to maybe update the schema file, just like it does for changelog files? |
Oh, nice. Could it work this way? Every change in I'm not sure I'll have time to look at this before end of year given holidays, etc. but it sounds interesting! |
Follow-up to #66675
Core backport at https://github.com/WordPress/wordpress-develop/pull/8031/files
What?
Make duotone and aspect ratios translatable to the block level (details).
Why?
Without this, the strings are not translatable.
How?
Adds duotone & aspect ratios under
settings/blocks/*
, so strings defined at these places are extracted for translation.Testing Instructions
None. This will be picked by the wp-cli/i18n-command when merged in wordpress-develop.