List View: fix appender size #68221
Merged
List View: fix appender size #68221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +43 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d6d9ad6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12468057102
|
tyxla
reviewed
Dec 23, 2024
| padding: 0; | ||
|
|
||
| // TODO: Consider passing size="small" to the Inserter toggle instead. | ||
| // Special dimensions for this button. | ||
| &.block-editor-inserter__toggle { |
There was a problem hiding this comment.
Hmm, won't this result in a more specific selector, but with duplicate classname:
.list-view-appender .block-editor-inserter__toggle.block-editor-inserter__toggle
I'd expect a single use of the .block-editor-inserter__toggle classname, and the extra specificity could come from using the other classes (.has-icon.is-next-40px-default-size)
There was a problem hiding this comment.
I thought it would be better to avoid using class names derived from components packages as much as possible, just like class names with .compnents- prefixes. Is it okay to use .has-icon or .is-next-40px-default-size?
There was a problem hiding this comment.
I agree it's not ideal to use those classes, but if you don't use them at all, or just use one, precedence will likely not be enough.
Alternatively, you could always use !important and once the TODO to small size buttons intentionally is addressed, this will no longer be an issue.
There was a problem hiding this comment.
Updated by d6d9ad6👍
t-hamano
force-pushed
the
fix/list-view-appender
branch
from
58f2ed4 to
d6d9ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #68155
What?
The list view appender is expected to be 24px in size, but due to the low specificity of the CSS selector it appears to have changed to 40px wide:
How?
As this comment says, ideally we should consider using
size="small"prop instead of custom CSS, but for now I increased the specificity of the CSS selector and overridden it with a 24px size.I've also replaced some hard-coded values with SCSS variables.
Testing Instructions
Open the Navigation block's sidebar to see the size of the appender.
Note: As far as I know, the Navigation block's sidebar is the only place where the appender is displayed in the list view.
Screenshots or screencast