-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs: use correct ariakit type for root component #68207
Conversation
Flaky tests detected in b587b81. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12435666330
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, LGTM 👍
@@ -22,7 +22,7 @@ export type TabsProps = { | |||
* `Tabs.Tablist` component and as many instances of the `Tabs.TabPanel` | |||
* components as there are `Tabs.Tab` components. | |||
*/ | |||
children: Ariakit.TabProps[ 'children' ]; | |||
children: Ariakit.TabProviderProps[ 'children' ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it all makes sense! 👍
What?
Fix prop type definitions for the
Tabs
component by importing type defs from the correct ariakit componentWhy?
Correctness
How?
Change from
TabProps
(the single tab) toTabProviderProps
(the tab provider)Testing Instructions
Tabs
component