Create Block: Allow external templates to customize more fields #68193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Enhancement
7 tasks
|
Size Change: -37 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 84e38d5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12433424451
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
A potential follow-up is to include prompts for all newly introduced fields. The alternative could be to wait until the work from @eduwass is finished and leave that decision to template authors: |
gziolo
force-pushed
the
update/create-block-customize-plugin-fields
branch
from
16a85b1 to
84e38d5
Compare
gziolo
added
the
Good First Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow external templates to customize additional plugin header and readme fields: "Requires at least", "Requires PHP", and "Tested up to".
Why?
These fields were hardcoded and keeping them up to date for every single template is rather difficult. This way we will be able to improve the process of updating these values as the number of templates increased over time.
How?
Introduced three new variables to use with external templates:
requiresAtLeast(default:'6.7') – the lowest WordPress version that the plugin will work on.requiresPHP(default:'7.4') – the minimum required PHP version for use with this plugin.testedUpTo(default:'6.7') – the highest WordPress version that the plugin has been tested against.PHP 7.4 is the minimum required version for WordPress as noted in WordPress requirements.
WordPress 6.7 is the current major version.
Testing Instructions
Testing Instructions for Keyboard
Run the scaffolding and ensure that default versions are set: