-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylebook: add the Appearance -> Design submenu through admin_menu
action
#68174
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @fushar! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this. LGTM
Changes to PHP files need a backport reference.
It looks like @tellthemachines has already got a draft up at so you could use WordPress/wordpress-develop#7865 as the backport reference.
Basically, it means adding this PR's URL to the existing md file: https://github.com/WordPress/gutenberg/blob/trunk/backport-changelog/6.8/7865.md?plain=1
After that, I think it's good to go 👍🏻
Thanks @ramonjd for the pointer; I've updated the PR as per your suggestion! |
What?
This PR is an improvement to #66851.
Some plugins are triggering the
admin_menu
action directly to populate the admin menus of a site. Here, I am proposing that we add the Appearance -> Design submenu via that action instead ofadmin_init
.Testing Instructions