-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Prepare for hard deprecation #68158
Conversation
dc7d303
to
6c8070a
Compare
Flaky tests detected in 6c8070a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12423238384
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add JS doc @deprecated
comments here, similarly to what we've done for other components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also add a README callout as we do for other hard deprecated components:
<div class="callout callout-alert">
This component is deprecated.
</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for writing a dev note proactively 🌟
They were marked in the source files when we first passive deprecated them. It should already be working as expected:
Also already done when we passive deprecated it 👍 |
What?
Starts logging a deprecation warning for
Navigation
, with an explicit end version.Why?
After passive deprecating (#61099) this component, we have had to do maintenance work on it many times. Given the low usage, I think it would be beneficial to eventually hard remove this code from the codebase.
Testing Instructions
✅ Deprecation warning should be logged in the Storybook.
✅ Unit tests should pass.
✍️ Dev Note
The
Navigation
component (and all its subcomponents) are deprecated, planned for hard removal in WordPress 7.1. Use theNavigator
component instead.