Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Button size violations in misc. unit tests #68154

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented Dec 19, 2024

In preparation for #65751

What?

Fixes some remaining Button size violations in unit tests.

Why?

So they do not log deprecation warnings when we start logging them for Button.

(FYI there are more violations remaining, but will be in logically-grouped PRs for easier review.)

Testing Instructions

✅ Unit tests still pass, and no functional changes.

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Dec 19, 2024
@mirka mirka self-assigned this Dec 19, 2024
Copy link

Flaky tests detected in 99af43e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12421446833
📝 Reported issues:

@mirka mirka marked this pull request as ready for review December 20, 2024 00:44
@mirka mirka requested a review from ajitbohra as a code owner December 20, 2024 00:44
Copy link

github-actions bot commented Dec 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka requested a review from a team December 20, 2024 00:44
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

So cool to see we're almost there 🚀

@mirka mirka merged commit a9f93d8 into trunk Dec 20, 2024
73 checks passed
@mirka mirka deleted the button-size-tests branch December 20, 2024 14:24
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants