Page - Quick Edit: add E2E tests #68151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
changed the title
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f00aa86. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12437480511
|
gigitux
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gigitux
force-pushed
the
test/e2e-quick-edit
branch
from
ae8fc97 to
cc3c2ea
Compare
gigitux
force-pushed
the
test/e2e-quick-edit
branch
from
cc3c2ea to
f00aa86
Compare
oandregal
reviewed
Dec 24, 2024
| const selectElement = page.locator( | ||
| 'select:has(option[value="1"])' | ||
| ); | ||
| await selectElement.selectOption( { value: '1' } ); |
There was a problem hiding this comment.
This is re-selecting the same author (admin), and we don't test the edited state. Perhaps we add a new author as part of the test.
oandregal
reviewed
Dec 24, 2024
| @@ -53,4 +61,356 @@ test.describe( 'Page List', () => { | |||
| page.getByRole( 'searchbox', { name: 'Search' } ) | |||
| ).toHaveValue( 'Privacy' ); | |||
| } ); | |||
|
|
|||
| test.describe( 'Quick Edit Mode', () => { | |||
| const fields = { | |||
oandregal
reviewed
Dec 24, 2024
| const dateEl = page.getByLabel( 'Edit Date' ); | ||
| await dateEl.click(); | ||
| const date = new Date(); | ||
| const yy = Number( date.getFullYear() ); |
There was a problem hiding this comment.
Nit: for a moment, my mind read this as if the year was two-digits — which is not what we render on screen. Naming this year or yyyy would be clearer.
oandregal
reviewed
Dec 24, 2024
| } ) | ||
| ).toBeVisible(); | ||
| }, | ||
| assertEditedState: async () => {}, |
There was a problem hiding this comment.
Not for this PR, but we could try to add a test for when the slug is actually editable.
oandregal
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request includes significant enhancements to the end-to-end tests for the site editor's page list functionality. The changes introduce new external dependencies, refactor existing test setup, and add comprehensive tests for the quick edit mode.
This PR adds E2E tests to cover the Quick Edit mode in the site editor's page list functionality.
These tests cover all the current implemented fields.
There are two tests that are blocked by #68173 and #67584. Once that this PR is merged, I will create a dedicated issue to ensure that we don't forget to implement them.