-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assets: Add README.md about syncing #68128
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just sync this file too, it will be helpful on both ends. I doubt it will cause any issues.
Flaky tests detected in 510e4e6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12412634829
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review.md is a great solution. Thank yiu.
Once back from Year-end vacation, I will see if there is also a place in the block editor handbook to add additional documentation there especially about the blueprint for Playground.
Co-authored-by: Jon Surrell <[email protected]>
Co-authored-by: Jon Surrell <[email protected]>
Co-authored-by: Jon Surrell <[email protected]>
Co-authored-by: Jon Surrell <[email protected]>
The sync workflow ran; the README was synced to svn 🎉 |
What?
Add a README.md to the
assets/
directory, to document how it is synced to the plugin repository.Follow-up to #68052. See #68052 (comment).
Why?
It's not that obvious.
How?
Add that README, plus the required provisions to exclude it from being synced to the plugin repo itself.
Testing Instructions
I've pushed this branch to my personal fork's
trunk/
. The README is found here; note that the workflow indeed hasn't been triggered by it.