Background supports: add default controls supports #68085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default controls. There is only "one" control officially, but at least this change allows blocks to control it pulling it in line with other blocks.
ramonjd
added
[Type] Bug
71 tasks
|
Size Change: +6 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Thanks for the quick fix @ramonjd 🚀
Bonus points for the top-notch PR description too!
It was considered to remove the redundant __experimentalDefaultControls settings from the block.json files for Group, Post Content, Verse et. al.
However I think we could leave them in as an explicit flag if the component's default ever updates.
This makes sense to me 👍
There's also some precedent for this approach with block support flags being explicitly opted into when the support is enabled by default.
I tested this PR tweaking the group and verse configurations around in block.json and via filters. Everything worked as expected.
| Default Control | Optional Control |
|---|---|
 |
 |
LGTM 🚢
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I appreciate the speedy 👀 Thanks @aaronrobertshaw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #54336
What?
It was an oversight not to check block settings for background image default controls.
There is only "one" control officially, but at least this change allows blocks to control it pulling it in line with other blocks.
This PR passes the support settings to the component in the block style hook.
Thanks to @aaronrobertshaw for spotting it.
Why?
Blocks that support background images such as the Group block have explicitly opted into the background image default control:
But that value has not effect when, in fact, the same settings are hardcoded in the component.
The consequence is that setting the control to
falsedoes nothing.It was considered to remove the redundant
__experimentalDefaultControlssettings from the block.json files for Group, Post Content, Verse et. al.However I think we could leave them in as an explicit flag if the component's default ever updates.
There are still a few outstanding inconsistencies with background image supports, most of which have been noted in #54336
Testing Instructions
Insert a Group block, select it and check the styles in the block settings panel.
The background image control should be visible by default.
Now set the defaultControl to
false:The background image control should not be visible by default.
Screenshots or screencast