Try splitting style book into sections. #68071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Enhancement
|
Size Change: +95 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
tellthemachines
force-pushed
the
try/style-book-preview-sections
branch
from
34531f6 to
81f7a75
Compare
|
Flaky tests detected in ad39bce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12458003651
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
E2e failure is legit; I messed something up in the classic stylebook 😬 fixing now |
|
...and just fixed another little boo-boo 😄 |
ramonjd
reviewed
Dec 20, 2024
| : { | ||
| examples: [ | ||
| examples.find( | ||
| ( example ) => example.name === previewCategory |
There was a problem hiding this comment.
comments-pagination, list-item and maybe some other blocks don't have any examples and will bork the whole page.
/wp-admin/site-editor.php?p=%2Fstyles§ion=%2Fblocks%2Fcore%252Fcomments-pagination&preview=stylebook
/wp-admin/site-editor.php?p=%2Fstyles§ion=%2Fblocks%2Fcore%252Flist-item&preview=stylebook
Some other blocks are listed on #64707. Also there are links to PRs where we created missing block examples.
There was a problem hiding this comment.
Oh I just fixed that! Blocks without examples should now just show the all blocks page, I think that's the best we can do until we get all the examples added.
|
Thanks for reviewing!
Do you think so? Because we still have a couple longish pages (Typography and all blocks) I thought it might be good to keep it in place for now. Anything specific seem off about it? |
Ah, not at all. I must have been only testing with short pages. Makes sense to keep it intact for the longer pages. 🍺 |
|
I made a couple of adjustments to the scrolling logic so that it now only scrolls long pages to the top and removed the block-specific logic as that's no longer needed with the individual block pages. |
ramonjd
reviewed
Dec 22, 2024
| if ( | ||
| path === '/' || | ||
| path.startsWith( '/typography' ) || | ||
| path.startsWith( '/blocks' ) |
There was a problem hiding this comment.
Should /colors also be here? Without, there's no scroll to top
Kapture.2024-12-23.at.08.59.48.mp4
I'll tentatively add it
ramonjd
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Split style book into sections according to the latest designs.
Testing Instructions
Screenshots or screencast
stylebooksections.mp4