Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Refactor display panel to use ToolsPanel #68011

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Navigation: Refactor display panel to use ToolsPanel #68011

wants to merge 4 commits into from

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Dec 16, 2024 •
edited
Loading

Part of: #67813

What?

Update Navigation Block to Implement ToolsPanel and ToolsPanelItem Components for Display Panel; Adjust Styles for Migration Compatibility.

Screenshots

Before After
image image

@yogeshbhutkar yogeshbhutkar mentioned this pull request Dec 16, 2024
Open
@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Dec 16, 2024
@fabiankaegy fabiankaegy linked an issue Dec 16, 2024 that may be closed by this pull request
Refactor "Display" panel of Navigation block to use ToolsPanel instead of PanelBody #67935
Open
@SainathPoojary SainathPoojary marked this pull request as ready for review December 23, 2024 07:10
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor "Display" panel of Navigation block to use ToolsPanel instead of PanelBody
2 participants
@SainathPoojary @fabiankaegy