Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Unite inline Ariakit imports #67818

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 11, 2024

What?

Unifies Ariakit imports in a few components.

Why?

In #64648 we introduced separate Ariakit imports needlessly.

How?

Combining them into a single import in this PR.

Testing Instructions

The build should pass, and all checks should be green.

Testing Instructions for Keyboard

Same

Screenshots or screencast

None

@tyxla tyxla added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Dec 11, 2024
@tyxla tyxla requested review from Mamaduka and a team December 11, 2024 09:44
@tyxla tyxla self-assigned this Dec 11, 2024
@tyxla tyxla requested a review from ajitbohra as a code owner December 11, 2024 09:44
Copy link

github-actions bot commented Dec 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for follow-up, @tyxla!

@tyxla tyxla enabled auto-merge (squash) December 11, 2024 10:18
@tyxla tyxla merged commit db42416 into trunk Dec 11, 2024
71 of 72 checks passed
@tyxla tyxla deleted the update/unite-ariakit-imports branch December 11, 2024 10:19
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 11, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants