[Dataviews] Fix: Space does not triggers the media button on grid view. #67791
Conversation
jorgefilipecosta
added
[Type] Bug
| if ( event.key === 'Enter' || event.key === '' ) { | ||
| if ( | ||
| event.key === 'Enter' || | ||
| event.key === '' || |
There was a problem hiding this comment.
What's the key related to empty space?
There was a problem hiding this comment.
In my testing, I needed to add ' ' because space was triggering it. But supposedly '' which was already there can also be for space so I left both.
There was a problem hiding this comment.
I wonder if the empty string was just mistyping for SPACE key? cc @youknowriad @gigitux who were involved in this, if my memory doesn't fail me.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
deleted the
fix/space-does-not-triggers-the-media-button-on-grid-view
branch
…w. (WordPress#67791) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: oandregal <[email protected]>
Fixes an issue reported by @oandregal at #67690 (comment). Currently while pressing space on the media button in the grid view the button is not triggered as expected. This PR fixes the issue.
Testing Instructions
Goto http://localhost:7888/site-wp-dev/wp-admin/site-editor.php?p=%2Fpage&layout=grid
Focus the search field tab until you focus a grid item press space and verify the button is triggered as expected.