Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Link UI: Remove onClose from onSelectBlock #67760

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Navigation Link UI: Remove onClose from onSelectBlock #67760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/block-library/src/navigation-link/link-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export function getSuggestionsQuery( type, kind ) {
}
}

function LinkUIBlockInserter( { clientId, onBack, onSelectBlock } ) {
function LinkUIBlockInserter( { clientId, onBack } ) {
const { rootBlockClientId } = useSelect(
( select ) => {
const { getBlockRootClientId } = select( blockEditorStore );
Expand Down Expand Up @@ -140,7 +140,6 @@ function LinkUIBlockInserter( { clientId, onBack, onSelectBlock } ) {
prioritizePatterns={ false }
selectBlockOnInsert
hasSearch={ false }
onSelect={ onSelectBlock }
/>
</div>
);
Expand Down Expand Up @@ -203,10 +202,6 @@ function UnforwardedLinkUI( props, ref ) {
`link-ui-link-control__description`
);

// Selecting a block should close the popover and also remove the (previously) automatically inserted
// link block so that the newly selected block can be inserted in its place.
const { onClose: onSelectBlock } = props;

return (
<Popover
ref={ ref }
Expand Down Expand Up @@ -287,7 +282,6 @@ function UnforwardedLinkUI( props, ref ) {
setAddingBlock( false );
setFocusAddBlockButton( true );
} }
onSelectBlock={ onSelectBlock }
/>
) }
</Popover>
Expand Down
Loading