Shadows: Improve design and a11y of remove button #67705
Merged
+47
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +42 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Wonderful PR, thank you for the before and after. From judging that alone, this one is good to go. I wasn't able to find these controls in testing, though, I suspect it's something with my env that I'll have to look into, so someone else will have to give the thumbs up. |
madhusudhand
approved these changes
Dec 9, 2024
|
Thank you everyone for your reviews! |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: madhusudhand <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes two improvements to the Shadow Panel reset button:
Why?
A reset button is being added to the color controls in #67116. That PR hasn't been merged yet, but it should eventually work like this:
32cbb47d36599ac1425826cd91fab09a.mp4
The reset button in the Shadow panel also needs to be updated to match the design of that button.
Testing Instructions
Screenshots or screencast
Below is a list of states under which visual changes occur.