Fix: Dataviews remove primary field concept from some classes. #67689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
|
Size Change: -14 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 6, 2024
| @@ -86,7 +86,7 @@ function GridItem< Item >( { | |||
| item, | |||
There was a problem hiding this comment.
What about the name of the variable here clickablePrimaryItemProps.
There was a problem hiding this comment.
Good catch, it was updated 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I wouldn't say we removed the "primary" concept entirely, we still have a "primary column" for instance in the table view but yeah this PR is good. |
jorgefilipecosta
force-pushed
the
fix/remove-the-primary-field-concept-from-missing-css-classes
branch
from
9e074df to
750d5fc
Compare
youknowriad
approved these changes
Dec 6, 2024
jorgefilipecosta
force-pushed
the
fix/remove-the-primary-field-concept-from-missing-css-classes
branch
from
750d5fc to
3123d8a
Compare
jorgefilipecosta
deleted the
fix/remove-the-primary-field-concept-from-missing-css-classes
branch
ramonjd
added
the
[Feature] DataViews
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…ress#67689) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #67477 we removed the concept of primary field, but we missed the update on some CSS classes, in order to consistent with the prop/API name. This PR updates the missing classes I found.
Testing Instructions
Verified the dataviews layouts still look the same.