Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve styling attributes during transformation to list blocks. #67685

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

snehapatil2001
Copy link
Contributor

@snehapatil2001 snehapatil2001 commented Dec 6, 2024

#67619

What?

This PR ensures that styling, such as fontSize, textColor and backGround, is preserved when transforming a block into a List block. Previously, these styles were lost when transforming the block.

Why?

This PR addresses the issue and ensures that the styles are carried over, improving the block transformation experience.

How?

  • The logic in block-library/src/list/transforms.js has been updated to capture the attributes from blocks during transformation.
  • These attributes are then retained when transforming into a List block, preventing the styling loss.

Testing Instructions

  1. Open the block editor in Gutenberg.
  2. Add a Paragraph block and apply typography styles (e.g., font size, text color).
  3. Transform the Paragraph block into a Heading block and verify that the styles are preserved.
  4. Revert the Heading block back to the Paragraph block and ensure the styles remain.
  5. Transform the Paragraph block into a List block and confirm the styles carry over.
  6. Revert the List block back to a Paragraph block and verify the original styles are maintained.

Testing Instructions for Keyboard

  • Use the Tab key to navigate and select the Paragraph block.
  • Apply styles using the block toolbar.
  • Transform the block using the block options menu and verify the styling persists in the List block.
  • Use the keyboard to navigate between blocks and check that styles are correctly preserved.

video

Screen.Recording.2024-12-06.at.4.35.59.PM.mov

Copy link

github-actions bot commented Dec 6, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Dec 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: snehapatil2001 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant