Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Tools: Don't render inserter in Zoom Out Dropzone when text is visible #67608

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Dec 5, 2024

Fixes: #67568

What?

This PR introduces a new state handling logic to determine whether or not the Inserter should be rendered on zoom out to prevent possible overlap with the pre-existing text.

Testing Instructions

  1. Navigate to Edit a Page screen.
  2. Zoom Out the Page.
  3. Click on the + Button to open up the pattern inserter.
  4. Notice the + Button from inserter disappears and the Drop Pattern is now visible instead of the previous overlap.

Screencast

Screen.Recording.2024-12-06.at.10.38.23.AM.mov

Screenshots

Before:
before

After:
Screenshot 2024-12-06 at 10 36 04 AM

@yogeshbhutkar
Copy link
Contributor Author

This PR is still work in progress, will update here once done.

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review December 6, 2024 05:09
Copy link

github-actions bot commented Dec 6, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Dec 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: getdave <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar
Copy link
Contributor Author

This PR is ready to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show inserter in Zoom Out dropzone when the text is visible
1 participant