WP Scripts: Update webpack dependencies related to styling #67572
+418
−514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -38 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
gziolo
commented
Dec 4, 2024
| @@ -103,7 +103,7 @@ const baseConfig = { | |||
| target, | |||
| output: { | |||
| filename: '[name].js', | |||
| chunkFilename: '[name].js?v=[chunkhash]', | |||
| chunkFilename: '[name].js?ver=[chunkhash]', | |||
There was a problem hiding this comment.
WordPress adds ?ver= to all urls. I updated it for consistency. It doesn't matter in practice.
gziolo
force-pushed
the
update/sass-dependency
branch
from
d694d83 to
880192f
Compare
gziolo
commented
Dec 4, 2024
| @@ -149,8 +149,8 @@ | |||
| "resize-observer-polyfill": "1.5.1", | |||
| "rimraf": "3.0.2", | |||
| "rtlcss": "4.0.0", | |||
| "sass": "1.35.2", | |||
| "sass-loader": "12.1.0", | |||
| "sass": "1.50.1", | |||
There was a problem hiding this comment.
There is a more up-to-date version of sass,, but there are too many deprecations reported in the Gutenberg codebase, so I went with the highest possible version that doesn't warn. It isn't essential for the fix, but I thought it would be great to bump the version as part of the effort.
|
Flaky tests detected in 8f6dd7d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12195334190
|
sirreal
approved these changes
Dec 4, 2024
gziolo
force-pushed
the
update/sass-dependency
branch
from
36a2f92 to
8f6dd7d
Compare
This was referenced Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the deprecation notice reported from
sass-loader:Steps to reproduce:
npx @wordpress/create-block@latest my-block cd my-block npm run buildWhy?
It was raised during the Developer Hours: Improve your workflows with WordPress development tools yesterday as a concern that it might to stop working.
How?
Updated several webpack dependencies in
@wordpress/scriptspackage.Testing Instructions
Creating a test plugin with SCSS files and running
npm run buildshould do the trick. This is the commands I used for testing in Gutenberg:npx wp-create-block my-block --no-wp-scripts cd my-block ../node_modules/.bin/wp-scripts build