Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Create a single component for rendering the actions list #67558

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ntsekouras
Copy link
Contributor

What?

I was looking at #66808 and saw that super small improvement for reusing the actions list.

Testing Instructions

  1. Anything action related in DataViews should work as before.

@ntsekouras ntsekouras added [Type] Code Quality Issues or PRs that relate to code quality [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Dec 4, 2024
@ntsekouras ntsekouras self-assigned this Dec 4, 2024
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I couldn't spot a regression when testing ✅

Copy link

github-actions bot commented Dec 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal
Copy link
Member

The reactnative tests are failing for unrelated reasons. Created a PR at #67586 but I'm unsure that'd solve it.

@ntsekouras ntsekouras merged commit 3ea3ba2 into trunk Dec 5, 2024
69 of 71 checks passed
@ntsekouras ntsekouras deleted the refactor/dataviews-actions-list branch December 5, 2024 10:04
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 5, 2024
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants