Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include arrows in pagination links #67555

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Takshil-Kunadia
Copy link
Contributor

Fixes #66040

What?

Including arrows markup when creating links.

Why?

Post navigation block arrow icon aren't clickable

How?

  • Create Arrows markup
  • Add arrows in navigation links markup according to the block attributes selected

Testing Instructions

  • Create a few posts.
  • Add Post Navigation pattern in the posts.
  • Try toggling including label and post title when arrows are enabled and see front end.

Testing Instructions for Keyboard

Screenshots or screencast

Before After

@Takshil-Kunadia Takshil-Kunadia marked this pull request as ready for review December 6, 2024 05:26
Copy link

github-actions bot commented Dec 6, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Dec 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jennajaehnig.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jennajaehnig.

Co-authored-by: Takshil-Kunadia <[email protected]>
Co-authored-by: AnmolVerma404 <[email protected]>
Co-authored-by: ariful93 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post navigation block arrow icon aren't clickable
1 participant