Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert api-fetch package to TypeScript #67510

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Dec 3, 2024

Fixes #59087

What?

  • Convert api-fetch package to TypeScript
  • Improve types for API fetch to return dynamic value based on parse option
  • Convert the corresponding unit tests to TS
  • Expose apiFetch as named export

Why?

Improve the DX and fix an issue when used in ES Modules

How?

By renaming the files and updating types

Testing Instructions

  • CI should be happy

Copy link

github-actions bot commented Dec 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @alexsanford.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: alexsanford.

Co-authored-by: manzoorwanijk <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: dilipom13 <[email protected]>
Co-authored-by: anomiex <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo gziolo added [Package] API fetch /packages/api-fetch [Type] Code Quality Issues or PRs that relate to code quality labels Dec 3, 2024
@manzoorwanijk manzoorwanijk closed this by deleting the head repository Dec 6, 2024
@gziolo
Copy link
Member

gziolo commented Dec 6, 2024

Moved to #67669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] API fetch /packages/api-fetch [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants