-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed align right issue on avatar component #67494
base: trunk
Are you sure you want to change the base?
Fix: Fixed align right issue on avatar component #67494
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Quickly looking at the output of the Avatar block, it seems that the whole block is wrapped in the link, and the link is not part of the block itself. I think fixing that would be the correct approach. Would you be able to try that?
Yes, I will work on it today. |
This reverts commit edab7a5.
Hello @ellatrix, I have also reverted the initial commit related to css changes. |
resolves #67493
What?
Added styles for Align Right in editor.scss for block themes to resolve the issue where the Avatar component alignment was not working when the "Link to Profile" option was enabled.
Why?
The Align Right feature for the Avatar component was not functioning as expected in block-based themes (e.g., Twenty Twenty-Four, Twenty Twenty-Five) when the "Link to Profile" option was selected. This PR addresses that issue by ensuring that the alignment works correctly across block themes, ensuring consistency with classic themes like Twenty Twenty-One, where it worked fine.
How?
This PR modifies the editor.scss file to explicitly add and enforce styles for the Align Right option in the block editor for Avatar components.
It adds following style snippet.
Testing Instructions
Screencast
Before
Screen.Recording.2024-12-02.at.10.54.01.PM.mov
After
Screen.Recording.2024-12-02.at.11.08.50.PM.mov