Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed align right issue on avatar component #67494

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

Mayank-Tripathi32
Copy link
Contributor

@Mayank-Tripathi32 Mayank-Tripathi32 commented Dec 2, 2024

resolves #67493

What?

Added styles for Align Right in editor.scss for block themes to resolve the issue where the Avatar component alignment was not working when the "Link to Profile" option was enabled.

Why?

The Align Right feature for the Avatar component was not functioning as expected in block-based themes (e.g., Twenty Twenty-Four, Twenty Twenty-Five) when the "Link to Profile" option was selected. This PR addresses that issue by ensuring that the alignment works correctly across block themes, ensuring consistency with classic themes like Twenty Twenty-One, where it worked fine.

How?

This PR modifies the editor.scss file to explicitly add and enforce styles for the Align Right option in the block editor for Avatar components.

It adds following style snippet.

.wp-block-avatar.alignright {
	.components-resizable-box__container {
		float: right;
	}
}

Testing Instructions

  1. Activate a block-based theme, e.g., Twenty Twenty-Four or Twenty Twenty-Five.
  2. Add the Avatar component to a post or page using the block editor.
  3. Enable the "Link to Profile" option in the Avatar component settings.
  4. Set the alignment option to "Align Right".
  5. Save and preview the post/page.
  6. Repeat for classic theme.

Screencast

Before

Screen.Recording.2024-12-02.at.10.54.01.PM.mov

After

Screen.Recording.2024-12-02.at.11.08.50.PM.mov

@Mayank-Tripathi32 Mayank-Tripathi32 marked this pull request as ready for review December 2, 2024 17:45
Copy link

github-actions bot commented Dec 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: ellatrix <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Quickly looking at the output of the Avatar block, it seems that the whole block is wrapped in the link, and the link is not part of the block itself. I think fixing that would be the correct approach. Would you be able to try that?

@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Dec 23, 2024
@Mayank-Tripathi32
Copy link
Contributor Author

Hi! Quickly looking at the output of the Avatar block, it seems that the whole block is wrapped in the link, and the link is not part of the block itself. I think fixing that would be the correct approach. Would you be able to try that?

Yes, I will work on it today.

@Mayank-Tripathi32
Copy link
Contributor Author

Hello @ellatrix,
Thank you for your feedback. I’ve addressed the issue you highlighted regarding the wrapper in the editor incorrectly wrapping the block. I’ve implemented the necessary adjustments and would appreciate it if you could review the changes.

I have also reverted the initial commit related to css changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar Component: Align Right does not work on block themes
2 participants