Featured Image Block: Refactor setting panel #67456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +142 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
I discovered that the featured image block already has a Custom Resolution drop-down under dimension control. The questions i have now are,
|
I've added the The ideal outcome is that the placement of the resolution control would be consistent across all blocks. Where exactly the control makes the most sense, I'll defer to our design gurus. It might also pay to provide screenshots of the two current locations for comparison, or create a dedicated issue where it's final home can be discussed. |
|
How many of those were only just recent additions though that didn't take into account the precedent set by the Featured Image block? |
|
Resolution support in I added a resolution option under dimension control to the cover block, following the precedent set by the featured image block. However, after receiving feedback on the comment, I had to move it to the settings panel. |
Thanks for the digging @akasunil but the history detailed misses the biggest part of the question, the Featured Image block. I was hoping to understand whether the Featured Image had the resolution controls first before the Image block etc. To determine what the true precedent was. @richtabor, when you get a moment, could you confirm whether we should also be moving the Featured Image's resolution control to the settings panel? I suspect we will given recent directions but want to double check as more PRs are being spun up around this. |
aaronrobertshaw
changed the title
fabiankaegy
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Thanks for working on this. This works as expected 🚀
@aaronrobertshaw we've been tracking the refactor of all usages of the PanelBody to ToolsPanel in #67813 and have already merged several of these. So I would feel comfortable approving and merging this 👍
CleanShot.2024-12-13.at.23.57.25.mp4
|
Thank you @fabiankaegy, i'll merge this PR. but we still have few open questions regarding custom resolution control and its placement in featured image block. Would like to get some design feedback on it.
|
akasunil
deleted the
enhancement/enhancement/refactor-featured-image-block-control-panel
branch
I think we'd want to lean towards consistency both in terms of placement of the controls and using reusable components. There's also an argument that could be made around minimising changes too but I don't think that's a blocker here. If a switch from the custom resolution drop-down to the |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* Refactor setting panel of featured image block control * Fix link target attribute reset Co-authored-by: akasunil <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* Refactor setting panel of featured image block control * Fix link target attribute reset Co-authored-by: akasunil <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? & Why?
Fixes #67940.
Featured image block missing image resolution setting reported in #65350,
While working on implementation of Resolution option in Featured image block, Its appeared that
ResolutionToolscomponent is composed ofToolsPanelItem, it must be placed inside theToolsPanelcomponent. The current Settings panel does not use theToolsPanelcomponent, so the entire settings panel is refactored.Testing Instructions
Screenshots or screencast
Edit-Post-.Hello-world-.-.-gutenberg-.-WordPress.3.webm