Draft: Use Combobox for post-meta and custom sources block bindings.Initial commit #67447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Technical Prototype
|
Size Change: +102 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Can be useful if you have a lot. But now you have to search in order to see anything at all, even if you just have a few attributes. Is there a way to show at least, say, 8 items always? It's likely not going to be the majority of sites having such few attributes, if they use them at all. |
I think that's a I can add a |
I think you might want to set In terms of how many items to display, with the current item height there will be ~2-2.5 results displayed, so you might want to override the |
|
I added the height to be able to display more items. |
I understand the uncertainty there and I don't have strong feelings either way; my suggestion was mostly to address @jasmussen's concerns:
|
|
The main thing is striking the right balance. Forcing you to search if you have only two or three bindings may be too much, since that could be the 80% use case. |
If 80% of the time we'll have two or three bindings, then we might as well not use a combobox but just a regular select/dropdown field? |
|
To be fair, that's a question from my end! So far I've only used bindings for basic stuff, quote of the day, random image, that sort of thing. But depending on experience and feedback on these it could simply be a progressive thing, and that's perhaps what you suggest: if there are less than 10 bindings, just show them in the flyout. If there's more than 10, do the combobox. |
Sounds like a good plan to me 👍 And then the autofocusing wouldn't feel as awkward. |
|
All of these are just experiments to enable this discussions 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #67012. This time I'm experimenting with using the combobox for the custom source fields list selection. This allows to have a search box.
Testing Instructions
Demo:
combobox.mp4