Fix List View not updating when switching editor modes #67379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +12 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 05081d0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12066111233
|
aaronrobertshaw
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Appreciate the quick turnaround on the fix @talldan 🚀
This is testing as advertised. Bonus points on the added e2e as well 👍
| Design Mode | Write (Trunk) | Write (This PR) |
|---|---|---|
 |
 |
 |
LGTM 🚢
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
* Add back the editorTool dependency to getEnabledClientIdsTree * Add e2e test * Switch to getEditorMode selector ---- Co-authored-by: talldan <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Add back the editorTool dependency to getEnabledClientIdsTree * Add e2e test * Switch to getEditorMode selector ---- Co-authored-by: talldan <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a small bug I reintroduced in #67026.
When switching block editor modes, the List View doesn't update to shown the blocks that can be interacted with.
How?
#67026 removed some dependencies of the selector, but some changes were made that meant the
select( STORE_NAME ).__unstableGetEditorMode( state )dependency needed to be added back.This PR resolves the issue.
Testing Instructions
As this bug has happened before, I've added an e2e test to prevent further regressions.
In trunk: It doesn't change which is a bug
In this PR: It updates to show which blocks can be interacted with
Screenshots or screencast
Kapture.2024-11-28.at.16.54.35.mp4