Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#66454 - Use consistent label color #67355

Closed

Conversation

valerogarte
Copy link
Contributor

What?

Fixes #66454

Standardizes the label colors within the Gutenberg editor by replacing the lighter gray #757575 ($gray-700) with a darker gray #1e1e1e ($gray-900) for control and input labels.

Why?

The current use of #757575 for labels results in reduced readability and inconsistency across the editor's interface. By adopting #1e1e1e for all labels, we enhance legibility and ensure a uniform appearance, aligning with accessibility guidelines and improving the user experience.

How?

The CSS styles have been updated to apply #1e1e1e to all control and input labels. Specifically, in the styles.ts file of the toggle-group-control-option-base component, the color property has been changed from COLORS.gray[700] to COLORS.gray[900].

Testing Instructions

  1. Access the Editor: Open a post or page in the Gutenberg editor.
  2. Insert a Group Block.
    2.1. Click the "+" button to add a new block.
    2.2. Search for and select the "Group" block.)
  3. With the Group block selected, navigate to the "Styles" tab in the block settings sidebar.
  4. Add a Background Image:
    4.1. Locate the "Background" section and click on the "Background Image" field.
    4.2. Upload a new image or select one from the media library to set as the background.
  5. Review the Applied Changes:
    5.1. Click on the uploaded background image within the Group block.
    5.2. A pop-up will appear, allowing you to observe the applied changes.
  6. While still in the "Styles" tab, locate the "Typography" section.
    6.1. Review the typography settings to ensure the changes are applied as expected.

Testing Instructions for Keyboard

  1. Access the Editor:
    1.1. Open a post or page in the Gutenberg editor.
  2. Insert a Group Block:
    2.1. Press Ctrl + Alt + T (Windows/Linux) or ⌥ + ⌘ + T (Mac) to insert a new block before the selected block.
    2.2. Type /group and press Enter to add a Group block.
  3. Navigate to the "Styles" Tab:
    3.1. Press Alt + F10 to focus on the nearest toolbar.
    3.2. Use the Tab key to navigate to the block settings sidebar.
    3.3. Press Shift + Tab to move focus to the tabs within the sidebar.
    3.4. Use the arrow keys to select the "Styles" tab and press Enter.
    4.Add a Background Image:
    4.1. Press Tab to navigate to the "Background" section.
    4.2. Press Enter to activate the "Background Image" field.
    4.3. Use the Tab key to navigate to the "Upload" button and press Enter to upload a new image, or navigate to the "Media Library" button and press Enter to select an existing image.
    4.4. Use the arrow keys to select the desired image and press Enter to set it as the background.
  4. Review the Applied Changes:
    5.1. Press Esc to exit the media selection dialog.
    5.2. Press Tab to navigate back to the Group block in the editor.
    5.3. Use the arrow keys to select the uploaded background image within the Group block.
    5.4. Press Enter to open the pop-up and observe the applied changes.
    6 Verify Typography Settings:
    6.1. Press Esc to close the pop-up.
    6.2. Press Tab to navigate to the "Typography" section within the "Styles" tab.
    6.3. Use the arrow keys to review the typography settings and ensure the changes are applied as expected.

Screenshots or screencast

image

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Nov 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @gutenbergplugin.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: gutenbergplugin.

Co-authored-by: valerogarte <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: ajlende <[email protected]>
Co-authored-by: vipul0425 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: afercia <[email protected]>
Co-authored-by: benniledl <[email protected]>
Co-authored-by: gigitux <[email protected]>
Co-authored-by: dhruvang21 <[email protected]>
Co-authored-by: jeryj <[email protected]>
Co-authored-by: ndiego <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: benazeer-ben <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ntsekouras and others added 26 commits November 27, 2024 18:54
Unlinked contributors: annchichi.

Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: rogermattic <[email protected]>
Co-authored-by: oandregal <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: mtias <[email protected]>
Co-authored-by: mcsf <[email protected]>
* Autocomplete: Increase option height

* Add changelog

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: lysyjan <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: RolfKyburz <[email protected]>
Co-authored-by: strarsis <[email protected]>
Co-authored-by: danielbachhuber <[email protected]>
Co-authored-by: jeryj <[email protected]>
Co-authored-by: ajlende <[email protected]>
Co-authored-by: stokesman <[email protected]>
Co-authored-by: ndiego <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: colorful-tones <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: priethor <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: cbravobernal <[email protected]>
#67213)

* BorderControl: Add support for warning suppression

* BorderBoxControl: Suppress redundant warnings for deprecated 36px size

* Add changelog

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
…trol. (#66721)

* feat: Adds the deprecation warning for range control.

* docs: Adds deprecation changelog.

* feat: Suppress the redundant warnings.

* refactor: Supress redundant warnings.

---------

Co-authored-by: vipul0425 <[email protected]>
Co-authored-by: mirka <[email protected]>
* ComboboxControl: Update reset button size

* Add changelog

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
#67255)

* Block Manager: Make it a private component in the block editor package

* Move style import statement

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: youknowriad <[email protected]>
* Dashicons: Remove non-existent icons from type

* Update changelog

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mirka <[email protected]>
…s button. (#66606)

* Improve accessibility and consistency of the Revisions button.

* Simplify revisions button and add count.

* Remove no longer used stylesheet import.

* Simplify revisions count retrieval by using useGlobalStylesRevisions.

* Adjust after 67180.

* Remove duplicate import after rebase.

Co-authored-by: afercia <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: up1512001 <[email protected]>
)

* move default template types and template part areas to REST API

* fix logic

* fix E2E test

* move default template types and template part areas to REST API

* fix error

* remove not necessary file

* fix naming

* remove duplicate code

* remove duplicated code

* improve logic

* fix naming

* fix unit test

* update doc

* add unit test for getTemplateInfo function

* restore not necessary changes

* fix e2e test

* remove not necessary variable

* replace add_action with add_filter

* improve readibility code

* make getTemplateInfo private

* make templateAreas optional

* add default_template_part_areas and default_template_types

* move code to rest-api.php file

* remove not used import
* Block Editor: Correctly mark Block Comment SlotFills private
* Drop '__unstable' prefix
* Simplify private API exports

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: jsnajdr <[email protected]>
Co-authored-by: dhruvang21 <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: gigitux <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: oandregal <[email protected]>
* Block Editor: Add success notices for image editing
* Fix translators comment

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: ajlende <[email protected]>
* CustomGradientPicker: Prepare `Button`s for 40px default size

* Add changelog

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
…pping (#67314)


Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: annezazu <[email protected]>
* Icon: Improve `icon` prop usage docs in Storybook

* Fixup

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
* CircularOptionPicker: Update Button sizes

* Add changelog

* Update snapshot

* Fixup changelog

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
* Components contributing guide: Fix relative links

* Fix broken image

Co-authored-by: mirka <[email protected]>
Co-authored-by: tyxla <[email protected]>
draganescu and others added 4 commits November 27, 2024 18:54
Co-authored-by: draganescu <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: tellthemachines <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: maddisondesigns <[email protected]>
@draganescu
Copy link
Contributor

Bad rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a consistent color for all controls and inputs labels