Sidebar: Update appearance of active items #67318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @danielvann777. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 34c52be. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12073259227
|
|
It looks great ✨ |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Unlinked contributors: danielvann777. Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: fcoveram <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ptesei <[email protected]> Co-authored-by: joedolson <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Unlinked contributors: danielvann777. Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: fcoveram <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ptesei <[email protected]> Co-authored-by: joedolson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66554.
What / Why?
This PR updates the appearance of active menu items in the navigation sidebar to achieve two objectives:
How
$gray-800background to active stateThe increased font-weight is an a11y consideration, due to the contrast between the sidebar and active item backgrounds not being sufficient.
Testing Instructions
Before
befor.mp4
After
after.mp4