Fix: Font size select value mismatch #67309
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #67283
What?
The selected value gets updated in the font select after the next iteration. Thus leading to a lag in the correct value being displayed on the selector.
Why?
The state in store.getState() is updated after the setValue logic is completed. This results in the currentValue being out of sync with the state during the render cycle.
How?
There is no need for the current value to be fetched from the store created when we have the current value available as a prop. This PR makes the change of using that value directly instead of waiting for the store's value to be set and then fetch it.
Testing Instructions
twentytwentyfive
'stheme.json
. [ I have used this theme for demo, WP 6.8rc ].Screenshots or screencast
Screen.Recording.2024-11-26.at.4.46.47.PM.mov