Code quality: Fix typos #67304

szepeviktor · 2024-11-26T09:04:31Z

What?

Found few years of typos.

How?

Would you like me to work on it?

github-actions · 2024-11-26T09:04:49Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: szepeviktor <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: getdave <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-11-26T09:04:54Z

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions · 2024-11-26T09:05:08Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @szepeviktor! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

packages/block-editor/src/components/index.js

t-hamano

@szepeviktor Thanks for the cleanup.

I think this PR contains a lot of unnecessary changes that need to be fixed and go through all CI. Could you address these issues?

docs/manifest.json

packages/block-editor/src/components/global-styles/filters-panel.js

packages/components/src/combobox-control/test/index.tsx

packages/components/src/surface/test/__snapshots__/index.tsx.snap

packages/components/src/utils/strings.ts

packages/react-native-editor/__device-tests__/helpers/utils.js

packages/react-native-editor/bin/test-e2e-setup.sh

patches/react-autosize-textarea+7.1.0.patch

...ste-should-cut-partial-selection-and-merge-like-a-normal-delete---not-forward-2-chromium.txt

...d-paste-plain-text-in-plain-text-context-when-cross-block-selection-is-copied-2-chromium.txt

bin/plugin/commands/test/__snapshots__/changelog.js.snap

michalczaplinski

I'd recommend to severely limit the scope of this PR. It's very hard to review and approve 436 typos across 259 files. As previously noted, many of the "typos" are not really typos here at all.

How about starting with just the typos in markdown files and code comments?

szepeviktor · 2024-11-26T17:27:04Z

How about starting with just the typos in markdown files and code comments?

This is a good idea.
Although there are approx. 0 Markdown files involved and Typos works this way: typos -w.
So there is no --do-not-touch-the-code switch.

A) I could close this PR and provide you with my Typos configuration
B) I could work on this PR to remove all false positives

Please decide!

szepeviktor · 2024-11-26T18:00:34Z

I've done all I could.

t-hamano

Thanks for the update. I have left additional feedback.

Could you resolve the lint errors first to ensure it passes all CI? If you run npm run lint:js:fix, all lint errors will be resolved.

docs/manifest.json

docs/reference-guides/interactivity-api/core-concepts/server-side-rendering.md

docs/reference-guides/interactivity-api/core-concepts/using-typescript.md

packages/eslint-plugin/utils/constants.js

packages/react-native-aztec/android/settings.gradle

packages/react-native-bridge/android/build.gradle

packages/react-native-bridge/android/react-native-bridge/build.gradle

packages/react-native-bridge/android/settings.gradle

packages/block-library/src/cover/test/edit.native.js

szepeviktor · 2024-11-30T10:17:55Z

Thanks for the update. I have left additional feedback.

I've done all I could.
Please find another contributor who will finish this PR.

szepeviktor · 2024-11-30T10:24:43Z

All right. One last commit.

getdave

Thank you for all the effort here.

I would echo the comments of some other reviewers that it would be preferable to break this out into separate PRs for:

Markdown
Code comments
Code changes (e.g variable renaming...etc)

That would:

Make it easier to review
Easier to revert in case of Issue.

When reviewing 256 files for changes it's easy to miss how a given change might impact the file as a whole.

I'd certainly feel a lot more comfortable if it was possible.

szepeviktor · 2024-12-02T16:16:29Z

Hello Dave!

The thing is this PR is a typos exercise for me.
typos works like: typos -w

We need someone who can cherrypick files for your three categories.

szepeviktor · 2024-12-02T16:20:05Z

... maybe an LLM

docs/manifest.json

docs/reference-guides/interactivity-api/core-concepts/server-side-rendering.md

…ide-rendering.md

…to undestanding-global-state-local-context-and-derived-state.md

gziolo · 2024-12-23T08:56:34Z

@t-hamano, I addressed your feedback related to the slug change for the developer documentation page. I also rebased the PR with the latest changes from trunk. There are so many quality improvements that it would be worth bringing it to the finish line.

Could you resolve the lint errors first to ensure it passes all CI? If you run npm run lint:js:fix, all lint errors will be resolved.

Yes, all of the issues are reported because of differences with how Prettier formats code. By the way, it would be cool to have GitHub integration that can be triggered with the label to automatically fix such issues.

@szepeviktor, that a cool usage of the tool. Very impressive given the complexity of the Gutenberg codebase. Thank you for working on this PR.

docs/reference-guides/interactivity-api/core-concepts/using-typescript.md

packages/block-editor/src/components/text-transform-control/README.md

t-hamano · 2024-12-23T13:49:21Z

lib/class-wp-theme-json-gutenberg.php

@@ -3417,7 +3417,7 @@ protected static function should_override_preset( $theme_json, $path, $override

 	/**
 	 * Returns the default slugs for all the presets in an associative array
-	 * whose keys are the preset paths and the leafs is the list of slugs.
+	 * whose keys are the preset paths and the leaves is the list of slugs.


Note: This typo is already fixed in the core, so a backport changelog should not be necessary.

https://github.com/WordPress/wordpress-develop/blob/07be2445e45066147105206da08acf31bcee974d/src/wp-includes/class-wp-theme-json.php#L3386

…pescript.md

…ADME.md

t-hamano · 2024-12-23T13:53:47Z

@gziolo Thanks for the fix.

I've checked all the files again and we should be able to ship this PR.

Could you resolve the lint errors first to ensure it passes all CI? If you run npm run lint:js:fix, all lint errors will be resolved.

Yes, all of the issues are reported because of differences with how Prettier formats code. By the way, it would be cool to have GitHub integration that can be triggered with the label to automatically fix such issues.

What would it take to get the Static Analysis CI to pass? I checked out this branch and opened the file that is causing the lint error, but my code editor doesn't give any warnings 🤔

Fix typos

80c4cfc

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 26, 2024

spacedmonkey approved these changes Nov 26, 2024

View reviewed changes

Revert

e5e1faa

Mamaduka reviewed Nov 26, 2024

View reviewed changes

packages/block-editor/src/components/index.js Outdated Show resolved Hide resolved

t-hamano requested changes Nov 26, 2024

View reviewed changes

michalczaplinski added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 26, 2024

michalczaplinski reviewed Nov 26, 2024

View reviewed changes

bin/plugin/commands/test/__snapshots__/changelog.js.snap Outdated Show resolved Hide resolved

michalczaplinski requested changes Nov 26, 2024

View reviewed changes

Revert all false positives

73cceea

szepeviktor added 2 commits November 26, 2024 18:04

Revert even more false positives

d794037

Revert file rename

2ad2d7e

t-hamano reviewed Nov 30, 2024

View reviewed changes

Revert

d0ef9ae

Fix a snap

9221d78

getdave reviewed Dec 2, 2024

View reviewed changes

gziolo reviewed Dec 23, 2024

View reviewed changes

docs/manifest.json Outdated Show resolved Hide resolved

Update docs/manifest.json

3696753

gziolo reviewed Dec 23, 2024

View reviewed changes

docs/reference-guides/interactivity-api/core-concepts/server-side-rendering.md Outdated Show resolved Hide resolved

gziolo added 3 commits December 23, 2024 09:46

Update docs/reference-guides/interactivity-api/core-concepts/server-s…

a2b90ab

…ide-rendering.md

Rename understanding-global-state-local-context-and-derived-state.md …

2e851be

…to undestanding-global-state-local-context-and-derived-state.md

Merge branch 'trunk' into typos

91fa908

gziolo added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Dec 23, 2024

gziolo changed the title ~~Fix typos~~ Code quality: Fix typos Dec 23, 2024

t-hamano reviewed Dec 23, 2024

View reviewed changes

t-hamano added 2 commits December 23, 2024 22:50

Update docs/reference-guides/interactivity-api/core-concepts/using-ty…

193ec0d

…pescript.md

Update packages/block-editor/src/components/text-transform-control/RE…

016f36f

…ADME.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code quality: Fix typos #67304

Code quality: Fix typos #67304

szepeviktor commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

t-hamano left a comment

michalczaplinski left a comment

szepeviktor commented Nov 26, 2024 •

edited

Loading

szepeviktor commented Nov 26, 2024 •

edited

Loading

t-hamano left a comment

szepeviktor commented Nov 30, 2024

szepeviktor commented Nov 30, 2024

getdave left a comment

szepeviktor commented Dec 2, 2024 •

edited

Loading

szepeviktor commented Dec 2, 2024

gziolo commented Dec 23, 2024 •

edited

Loading

t-hamano Dec 23, 2024

t-hamano commented Dec 23, 2024

Code quality: Fix typos #67304

Are you sure you want to change the base?

Code quality: Fix typos #67304

Conversation

szepeviktor commented Nov 26, 2024 • edited Loading

What?

How?

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024

github-actions bot commented Nov 26, 2024

t-hamano left a comment

Choose a reason for hiding this comment

michalczaplinski left a comment

Choose a reason for hiding this comment

szepeviktor commented Nov 26, 2024 • edited Loading

szepeviktor commented Nov 26, 2024 • edited Loading

t-hamano left a comment

Choose a reason for hiding this comment

szepeviktor commented Nov 30, 2024

szepeviktor commented Nov 30, 2024

getdave left a comment

Choose a reason for hiding this comment

szepeviktor commented Dec 2, 2024 • edited Loading

szepeviktor commented Dec 2, 2024

gziolo commented Dec 23, 2024 • edited Loading

t-hamano Dec 23, 2024

Choose a reason for hiding this comment

t-hamano commented Dec 23, 2024

szepeviktor commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

szepeviktor commented Nov 26, 2024 •

edited

Loading

szepeviktor commented Nov 26, 2024 •

edited

Loading

szepeviktor commented Dec 2, 2024 •

edited

Loading

gziolo commented Dec 23, 2024 •

edited

Loading