CommentsPagination: Set font-size to inherit for pagination items #67296
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
added
[Block] Comments Pagination Previous
cbravobernal
added
the
[Type] Bug
cbravobernal
approved these changes
Nov 28, 2024
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
…rdPress#67296) * CommentsPagination: Set font-size to inherit for pagination items * Remove extra spaces --------- Co-authored-by: yogeshbhutkar <[email protected]> Co-authored-by: cbravobernal <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
…7296) * CommentsPagination: Set font-size to inherit for pagination items * Remove extra spaces --------- Co-authored-by: yogeshbhutkar <[email protected]> Co-authored-by: cbravobernal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #67295
What?
Inside the Comments Pagination block, updating the font sizes from the Typography Controls do not get reflected in the Editor as well as the Front End. This PR aims to resolve that issue.
Why?
This PR addresses a bug that does not let the font sizes of the items contained in the Comments Pagination block change upon changing the font size from the Typography Controls.
More info about the bug is reported in the issue.
How?
Using
font-size: inheritappears to resolve the issue.Testing Instructions
Screenshots or screencast
Screen.Recording.2024-11-26.at.12.55.52.PM.mov