Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: Add stories for HeadingLevelDropdown component #67294

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Storybook: Add stories for HeadingLevelDropdown component #67294

merged 4 commits into from
Dec 10, 2024

Conversation

Sukhendu2002
Copy link
Contributor

@Sukhendu2002 Sukhendu2002 commented Nov 26, 2024 •
edited
Loading

Part of #67165

What?

This PR will add stories for HeadingLevelDropdown component in the Storybook

Testing Instructions

  1. Run npm run storybook:dev
  2. Open the storybook on http://localhost:50240/
  3. Check the HeadingLevelDropdown stories.

Screenshots or screencast

Screenshot 2024-12-02 at 5 29 42 PM

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review November 26, 2024 06:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <[email protected]>
Co-authored-by: dcalhoun <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil mentioned this pull request Nov 28, 2024
Open
@akasunil akasunil added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Nov 28, 2024
dcalhoun
dcalhoun reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth waiting to merge until feedback is shared on #67165 (comment). It may also be worthwhile to request code review from those that respond, I have less context on the state or desires for Storybook usage.

packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js Outdated Show resolved Hide resolved
@Sukhendu2002 Sukhendu2002 requested a review from dcalhoun December 4, 2024 15:59
@dcalhoun
Copy link
Member

dcalhoun commented Dec 4, 2024

Thanks for addressing my feedback. 🙇🏻‍♂️

I'm removing the review request for myself, and requesting review by @t-hamano. I believe @t-hamano likely has better context for how the project would like to leverage Storybook.

@dcalhoun dcalhoun requested review from t-hamano and removed request for dcalhoun December 4, 2024 16:06
t-hamano
t-hamano reviewed Dec 8, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've made a few suggestions, but overall it seems good 👍

packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js Show resolved Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js Outdated Show resolved Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js Outdated Show resolved Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js Outdated Show resolved Hide resolved
packages/block-editor/src/components/block-heading-level-dropdown/stories/index.story.js Outdated Show resolved Hide resolved
@Sukhendu2002
Copy link
Contributor Author

Hi @t-hamano, Thanks for the feedback! I’ve updated it accordingly.

@Sukhendu2002 Sukhendu2002 requested a review from t-hamano December 9, 2024 06:21
t-hamano
t-hamano approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected 👍

957a160c3327387ab30d782e600d2313.mp4

@t-hamano t-hamano merged commit 101bbd2 into WordPress:trunk Dec 10, 2024
61 of 63 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 10, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
@Sukhendu2002 @dcalhoun
@t-hamano @yogeshbhutkar
Storybook: Add stories for HeadingLevelDropdown component (WordPress#…
771d4e8 
…67294)

* Storybook: Add HeadingLevelDropdown Stories

* Update HeadingLevelDropdown story to CSF 3

* Update control types

* Update HeadingLevelDropdown story for improved usability

Co-authored-by: Sukhendu2002 <[email protected]>
Co-authored-by: dcalhoun <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun left review comments

@t-hamano t-hamano t-hamano approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@carolinan carolinan Awaiting requested review from carolinan

Assignees
No one assigned
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 19.9
Development

Successfully merging this pull request may close these issues.
4 participants
@Sukhendu2002 @dcalhoun @t-hamano @akasunil