Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "Open in new tab" option to the navigation block's sidebar settings. #67291

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

pitamdey
Copy link

Fixes: #67246

What?

Adds the "Open in new tab" Option to the Navigation Link block's settings just like we do using Toolbar

Why?

The "Open in new tab" setting is currently limited to the link modal in the Toolbar, while other link options are located in the block settings sidebar. This inconsistency has led to confusion for editors trying to find this commonly used feature.

How?

I have added the same option in the sidebar like we have in the Toolbar

Screenshots or screencast

Screenshot 2024-11-26 at 11 18 25 AM

@pitamdey pitamdey requested a review from ajitbohra as a code owner November 26, 2024 05:49
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Nov 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pitamdey <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: relic-se <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 26, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pitamdey! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka
Copy link
Member

Thanks for contributing, @pitamdey!

It looks like the issue already has a PR - #67262.

@pitamdey
Copy link
Author

Yes, @Mamaduka, you are right. I can see that, but I have used a checkbox here and added the option similar to the toolbar.

@Mamaduka
Copy link
Member

I can see that, but I have used a checkbox here and added the option similar to the toolbar.

That's more of a design preference. I'm sure @Infinite-Null can also change the component to a checkbox if requested.

I don't have a personal preference here, but similar/duplicate PRs are usually closed in favor of the oldest active PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Link Block: Open in new tab
2 participants