-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an "Open in new tab" option to the navigation block's sidebar settings. #67291
base: trunk
Are you sure you want to change the base?
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @pitamdey! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Yes, @Mamaduka, you are right. I can see that, but I have used a checkbox here and added the option similar to the toolbar. |
That's more of a design preference. I'm sure @Infinite-Null can also change the component to a checkbox if requested. I don't have a personal preference here, but similar/duplicate PRs are usually closed in favor of the oldest active PR. |
Fixes: #67246
What?
Adds the "Open in new tab" Option to the Navigation Link block's settings just like we do using Toolbar
Why?
The "Open in new tab" setting is currently limited to the link modal in the Toolbar, while other link options are located in the block settings sidebar. This inconsistency has led to confusion for editors trying to find this commonly used feature.
How?
I have added the same option in the sidebar like we have in the Toolbar
Screenshots or screencast