Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure consistency in editor tools for navigation buttons and delete options #67253

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

sarthaknagoshe2002
Copy link
Contributor

@sarthaknagoshe2002 sarthaknagoshe2002 commented Nov 23, 2024

Fixes: #63991

What?

This PR addresses inconsistencies in the editor tools UI, focusing on:

Navigation Button Design: Ensures consistent use of chevrons for menu items like Shadows and Typography/Font Sizes, which navigate to edit screens.
Delete All Options: Adds or aligns "Delete All" functionality for custom settings like Shadows, Custom Font Sizes, and Colors.

Why?

Inconsistent UI elements create confusion for users and hinder the overall experience. Aligning the design and functionality of editor tools improves usability, accessibility, and coherence across the interface.

How?

Updated navigation button components to uniformly display chevrons for items that navigate to sub-settings (e.g., Shadows, Typography/Font Sizes).
Implemented consistent "Delete All" options for applicable settings, ensuring uniform behavior across Shadows, Custom Font Sizes, and Colors.
Adjusted CSS and component logic for styling and interactions to reflect these changes.

Testing Instructions

  1. Navigation Buttons

    • Check that Shadows and Typography/Font Sizes now show chevrons consistently.
  2. Delete All Options

    • Verify the "Delete All" option exists and works for Shadows, Custom Font Sizes, and Colors.

Screenshots or screencast

editor-shadow.options.mov

Copy link

github-actions bot commented Nov 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sarthaknagoshe2002 <[email protected]>
Co-authored-by: mikachan <[email protected]>
Co-authored-by: madhusudhand <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sarthaknagoshe2002
Copy link
Contributor Author

@mikachan Could you kindly review this PR?

@adamsilverstein adamsilverstein added the [Type] Enhancement A suggestion for improvement. label Dec 16, 2024
@mikachan mikachan added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. labels Dec 17, 2024
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I can see the shadow options are now more in line with the typography options, with the additional options menu and the confirm modal.

trunk Typography This PR
image image image

I've left a couple of inline comments. I think we should resolve the conflicts with trunk and then I'll give this another review 🙌

@sarthaknagoshe2002
Copy link
Contributor Author

@mikachan I’ve resolved the merge conflicts and addressed the feedback.

I also noticed that a tsconfig.json file added yesterday to the latest trunk has some linting issues, which were automatically rectified by the pre-commit git hooks. Unfortunately, I’m unable to undo those changes, as the linting check requires proper formatting before committing.

Could you please share any insights or suggestions on how to handle this?

@sarthaknagoshe2002
Copy link
Contributor Author

@mikachan I’ve resolved the merge conflicts and addressed the feedback.

I also noticed that a tsconfig.json file added yesterday to the latest trunk has some linting issues, which were automatically rectified by the pre-commit git hooks. Unfortunately, I’m unable to undo those changes, as the linting check requires proper formatting before committing.

Could you please share any insights or suggestions on how to handle this?

This is now resolved.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here, @sarthaknagoshe2002! I think this is ready to merge when the tests pass 🎉

@mikachan mikachan merged commit 9297500 into WordPress:trunk Dec 20, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 20, 2024
@sarthaknagoshe2002 sarthaknagoshe2002 deleted the fix/issue-63991 branch December 20, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent UI in editor settings
3 participants