-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ensure consistency in editor tools for navigation buttons and delete options #67253
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@mikachan Could you kindly review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I can see the shadow options are now more in line with the typography options, with the additional options menu and the confirm modal.
trunk | Typography | This PR |
---|---|---|
I've left a couple of inline comments. I think we should resolve the conflicts with trunk and then I'll give this another review 🙌
packages/edit-site/src/components/global-styles/shadows-panel.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/global-styles/shadows-panel.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/global-styles/shadows-panel.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/global-styles/shadows-panel.js
Outdated
Show resolved
Hide resolved
@mikachan I’ve resolved the merge conflicts and addressed the feedback. I also noticed that a Could you please share any insights or suggestions on how to handle this? |
This is now resolved. |
packages/edit-site/src/components/global-styles/shadows-panel.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/global-styles/shadows-panel.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/global-styles/shadows-panel.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah Norris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work here, @sarthaknagoshe2002! I think this is ready to merge when the tests pass 🎉
Fixes: #63991
What?
This PR addresses inconsistencies in the editor tools UI, focusing on:
Navigation Button Design: Ensures consistent use of chevrons for menu items like Shadows and Typography/Font Sizes, which navigate to edit screens.
Delete All Options: Adds or aligns "Delete All" functionality for custom settings like Shadows, Custom Font Sizes, and Colors.
Why?
Inconsistent UI elements create confusion for users and hinder the overall experience. Aligning the design and functionality of editor tools improves usability, accessibility, and coherence across the interface.
How?
Updated navigation button components to uniformly display chevrons for items that navigate to sub-settings (e.g., Shadows, Typography/Font Sizes).
Implemented consistent "Delete All" options for applicable settings, ensuring uniform behavior across Shadows, Custom Font Sizes, and Colors.
Adjusted CSS and component logic for styling and interactions to reflect these changes.
Testing Instructions
Navigation Buttons
Delete All Options
Screenshots or screencast
editor-shadow.options.mov