Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add section about the Fields API #66761

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Nov 5, 2024

What?

This PR extracts the Fields API to its own section and documents every one of its properties: type, required/optional, example, etc.

Testing Instructions

Read docs.

Copy link

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal self-assigned this Nov 5, 2024
@oandregal oandregal added [Type] Developer Documentation Documentation for developers [Package] DataViews /packages/dataviews labels Nov 5, 2024
@oandregal oandregal merged commit d50ff80 into trunk Nov 5, 2024
44 of 45 checks passed
@oandregal oandregal deleted the update/dataviews-docs-fields-api branch November 5, 2024 16:39
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Nov 5, 2024
@@ -67,7 +67,7 @@ By default, dataviews would use each record's `id` as an unique identifier. If t

#### `fields`: `Object[]`

The fields describe the visible items for each record in the dataset.
The fields describe the visible items for each record in the dataset and how they behave (how to sort them, display them, etc.). See "Fields API" as a reference for every property.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would help to link to the Fields API section to get there more easily.


### `type`

Field type. One of `text`, `integer`, `datetime`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of supported types is interesting. There are differences between block attributes or custom post type meta fields. Where can I learn more about plans related to that?

Edit: 'radio'
}

// Edit is optional when field's type is present.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool developer experience 👏

karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] DataViews /packages/dataviews [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants