BlockPatternsList: use the Async component #66744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -298 B (-0.02%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
mcsf
reviewed
Nov 5, 2024
| @@ -86,6 +87,9 @@ export function BlockPreview( { | |||
| ); | |||
| } | |||
|
|
|||
| BlockPreview = memo( BlockPreview ); | |||
There was a problem hiding this comment.
Minor point, but instead of reassigning values (which is more fragile, since now we need to be careful to place the assignment of BlockPreview.Async after it), we should fix this at the source:
export const BlockPreview = memo(
( {
...
} ) => {There was a problem hiding this comment.
I went for a rename in ca7fa6d because I'm not a fan of the extra indentation this creates. :)
mcsf
approved these changes
Nov 5, 2024
|
Thanks for the review! You are an experienced opinion! I feel confident about this so I'll merge, we can always tweak or revert if needed. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: mcsf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Since #60425, we use an Async wrapper component around the BlockPreview components for templates in DataViews. This PR uses the same approach for
BlockPatternsList, which currently usesuseAsyncList.Why?
State is managed more down the tree, which is easier from a dev ex perspective, but also more performant since it doesn't cause the whole list to re-render.
How?
I've moved Async to the BlockPreview component so it can be re-used.
Testing Instructions
There's quite a few places where we use BlockPatternsList, most notably in the patterns inserter, but also in the patterns explorer modal (accessed from the inserter), the template swap function, and the starter content modal.
✅ The Post Editor > loadPatterns metric does not regress.
Testing Instructions for Keyboard
Screenshots or screencast