Keep meta boxes in the interface content’s scrolling context for device previews #66726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +110 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Locally, I’ve fixed the conflicts caused by #66742 but can’t seem to push to this branch any longer. Did we miss the deadline to get this in? |
I also tried to push, but got the following error: Maybe it's because the branch name matches the following protection rule?
|
getdave
removed
the
Backport to WP 6.7 Beta/RC
|
This PR missed the final RC3 for WordPress 6.7. How critical do you feel it is that this lands in the release? I'm concerned that we've had a lot of flux around the metaboxes and scrolling and I'm conscious of not introducing any further changes that could have wider implications right before the release. For this reason, I'm minded that this should be something to target for 6.7.1. I appreciate that might not be ideal but we have to balance that carefully against potential for knock on effects. I'm curious to hear your opinions and also those of @kevin940726 @colorful-tones @ndiego. |
Yes. Please avoid |
I agree. We also have a few additional items that have been punted 6.7.1, so ideally, we could get that release out by the end of the year. I think it would be better to take a bit more time to make sure this implementation works well and also see if any other issues pop up once folks start using the new metabox layout in 6.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoids obscured device previews when meta boxes are present in the Post editor.
Why?
Fixes #66629 minimally with the solution proposed by Aki from the issue.
How?
Makes device previews a condition for displaying the meta boxes as they are when the canvas is not iframed and revises styling so there’s a no clipping of the fixed canvas height of device previews.
Testing Instructions
Device previews
Desktop view
Ensure the split view works as before:
Testing Instructions for Keyboard
Screenshots or screencast
meta-boxes-device-previews-same-scrolling-area.mp4