fix: wrong number of $accepted_args on add_filter() calls

[justlevine]

What?

This PR fixes several instances of the wrong number of $accepted_args being passed to add_filter(), so the match the correct number of args taken by their callbacks.

As the correct $accepted_args and $priority are the defaults once corrected, the explicit args have been removed entirely.

Why?

While this issue was surfaced by PHPStan (via #66693) it can be remediated independently as part of #66598

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
• Labels found: Gutenberg Plugin, [Type] Code Quality.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: justlevine <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: szepeviktor <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @justlevine! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[szepeviktor]

Yes, level 0 problems must be fixed.

I consider applications with level 4 problems broken.

[Mamaduka]

I think we can just omit $accepted_args when the value is one. It's the default value for hooks.

[justlevine]

I think we can just omit $accepted_args when the value is one. It's the default value for hooks.

Perhaps, but figured I'd match the existing patterns e.g.

gutenberg/lib/block-supports/block-style-variations.php

Line 278 in ee1039a

add_action( 'wp_enqueue_scripts', 'gutenberg_enqueue_block_style_variation_styles', 1 );

[Mamaduka]

The 1 in that example is $priority and not the $accepted_args. In any case, it was a minor nitpick, nothing blocker for this PR.

[gziolo]

Here and in other places 1 can be omitted as it's the default value. The same applies to the priority which also defaults to 10.

[justlevine]

@gziolo / @Mamaduka apologies, I thought I pushed this back in november 😅

Updated in 0beec7c