Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Pagination: Add border and spacing support #66470

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

rinkalpagdar
Copy link
Contributor

What?

Add border block support to the comments pagination block.
Part of #43247
Part of #43243

Why?

The comments pagination block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  1. Go to the Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  2. Make sure that the comments pagination block's border and spacing are configurable via Global Styles
  3. Verify that Global Styles are applied correctly in the editor and frontend
  4. Edit the template/page, Add a comments pagination block and Apply the border and spacing styles
  5. Verify that block styles take precedence over global styles
  6. Verify that block borders and spacing display correctly in both the editor and frontend

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added the [Type] Enhancement A suggestion for improvement. label Oct 29, 2024
@shail-mehta shail-mehta added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants