Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Template: Add border support #66441

Conversation

karthick-murugan
Copy link
Contributor

What?

Add border and spacing block support to the Post Template block.

Part of #43247

Why?

Post Template block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  • Go to Appearance > Editor > Styles > Edit Styles > Blocks.
  • Ensure the Post Template block's border is configurable via Global Styles.
  • Confirm Global Styles are applied correctly in both the editor and frontend.
  • Edit a template or page and add a Query Loop block.
  • Select a variation (e.g., Title & Date) to list all the posts.
  • Select the Post Template block and verify border and radius settings are available.
  • Check that block styles take precedence over Global Styles.
  • Ensure borders display correctly in both the editor and frontend.

Testing Instructions for Keyboard

None

Screenshots or screencast

In Frontend:

post_template_front1

In Backend:

post_template_front

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Oct 25, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: shail-mehta <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 25, 2024
@karthick-murugan karthick-murugan changed the title Post Template border support Post Template: Add border support Oct 25, 2024
@shail-mehta
Copy link
Member

Hi @karthick-murugan Thanks for the PR.

We are already tracking this here:
#64425

@karthick-murugan
Copy link
Contributor Author

@shail-mehta - Thanks for letting me know. That PR was hided and I missed. I am closing this PR now.

@karthick-murugan karthick-murugan deleted the add/post-template-border-support branch October 25, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants