RSS: Added Colour support #66419
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,26 @@ | |
| "html": false, | ||
| "interactivity": { | ||
| "clientNavigation": true | ||
| }, | ||
| "color": { | ||
| "background": true, | ||
| "text": true, | ||
| "gradients": true, | ||
| "link": true | ||
| }, | ||
| "typography": { | ||
| "fontSize": true, | ||
| "lineHeight": true, | ||
| "__experimentalFontFamily": true, | ||
| "__experimentalFontWeight": true, | ||
| "__experimentalFontStyle": true, | ||
| "__experimentalTextTransform": true, | ||
| "__experimentalLetterSpacing": true, | ||
| "__experimentalTextDecoration": true, | ||
|
There was a problem hiding this comment. Probably not a big deal, but the underline control in text decoration won't affect a:where(:not(.wp-element-button)) {
text-decoration: underline;
}I'm not sure whether users will expect text decoration to affect all text within the RSS block 🤔 There was a problem hiding this comment. There might be some options here to apply text decoration more effectively. Individual block support features, e.g. text-decoration, can have their serialization of styles and classes skipped. They can then be manually applied to the appropriate inner elements. For the Global Styles side of that equation, the Block Selectors API allows custom selectors for individual features so they target the same inner elements. For an example of skipping serialization of only Note: The navigation block skipped that serialization before the Selector's API was implemented so I'm not sure if it covers Global Styles or not. There was a problem hiding this comment. Thanks @aaronrobertshaw for the reference and suggestion. Tried to follow the same way as in the Navigation block. Bu as you mentioned, it doesn't covers Global Styles. We need to tweak more on this. I have added all the changes in recent commit. More suggestions are welcome for this scenario. |
||
| "__experimentalDefaultControls": { | ||
| "fontSize": true, | ||
| "textDecoration": true | ||
| } | ||
| } | ||
| }, | ||
| "editorStyle": "wp-block-rss-editor", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the
__experimentalprefixes now that #63401 has merged 👍🏻There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__experimental prefixes removed in recent commit.