Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline commenting - Change new comment input option to use Textareacontrol #66391

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

hbhalodia
Copy link
Contributor

Partof - #66377

What?

  • PR changes from Textcontrol to Textareacontrol to add the new comments.

Why?

  • Inline comments can be long so needs better UX to add the comments.

How?

  • PR updates to use Textareacontrol.

Testing Instructions

  1. Enable experimental inline commenting option.
  2. Go to any post/page.
  3. Add any block, check to add the inline comment.
  4. You would see the text area input to add the comment.

Testing Instructions for Keyboard

  • Nil

Screenshots or screencast

Screenshot 2024-10-24 at 9 44 06 AM

Copy link

github-actions bot commented Oct 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: akasunil <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ellatrix
Copy link
Member

Could you make it expand to the contents? I believe there's a component for it somewhere that we use.

@Mamaduka
Copy link
Member

I think that would be TextareaAutosize.

@hbhalodia
Copy link
Contributor Author

Could you make it expand to the contents? I believe there's a component for it somewhere that we use.

I think we need to use something like this, https://github.com/WordPress/gutenberg/blob/HEAD/packages/block-editor/src/components/plain-text/README.md but not sure, I tried this, but looks like we need more styling to add make it look like a component, but I guess this is what need here.

Screenshot 2024-10-25 at 10 05 58 AM

@hbhalodia hbhalodia requested a review from ellatrix October 25, 2024 04:37
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Oct 25, 2024
@akasunil
Copy link
Member

I think we need to use something like this, https://github.com/WordPress/gutenberg/blob/HEAD/packages/block-editor/src/components/plain-text/README.md but not sure, I tried this, but looks like we need more styling to add make it look like a component, but I guess this is what need here.

You're right. PlainText would be ideal in this situation, since TextareaAutosize is used internally in that component. What worries me, though, is that it has never been used outside of the block library, that why it has no styles also.

@ellatrix
Copy link
Member

Yes, we shouldn't use PlainText, it's meant for blocks. Let's stick with a textarea that autoresizes for now :)

@hbhalodia
Copy link
Contributor Author

Yes, we shouldn't use PlainText, it's meant for blocks. Let's stick with a textarea that autoresizes for now :)

Yes, thanks @ellatrix, for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants