-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline commenting - Change new comment input option to use Textareacontrol #66391
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Could you make it expand to the contents? I believe there's a component for it somewhere that we use. |
I think that would be |
I think we need to use something like this, https://github.com/WordPress/gutenberg/blob/HEAD/packages/block-editor/src/components/plain-text/README.md but not sure, I tried this, but looks like we need more styling to add make it look like a component, but I guess this is what need here. |
You're right. |
Yes, we shouldn't use PlainText, it's meant for blocks. Let's stick with a textarea that autoresizes for now :) |
Yes, thanks @ellatrix, for the confirmation. |
Partof - #66377
What?
Textcontrol
toTextareacontrol
to add the new comments.Why?
How?
Textareacontrol
.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast