Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toggle verb from post list data views 'Toggle details panel' #66334

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

AhmarZaidi
Copy link
Contributor

Fixes: #66319

What?

The verb 'toggle' isn't well translatable in many languages and should not be used.

Why?

Address part of #61483, improving localization.

How?

Removes 'Toggle' from 'Toggle details panel' and makes it 'Details panel'.
Not making it Title case as suggest here to keep in line with surrounding buttons.

Testing Instructions

  1. Go to Admin Dasbboard > Gutenberg > Experiments and enable Quick Edit in DataViews > Save changes
  2. Go to the Site editor > Pages
  3. Switch the data views to Table or Grid layout
  4. Notice that the button is now 'Details panel' button in the top bar

Testing Instructions for Keyboard

  1. Go to Admin Dasbboard > Gutenberg > Experiments and enable Quick Edit in DataViews > Save changes
  2. Go to the Site editor > Pages
  3. Switch the data views to Table or Grid layout
  4. Tab to the 'Details panel' button and notice that the label is updated to 'Details pane'

Screenshots or screencast

image

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AhmarZaidi! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 22, 2024
@AhmarZaidi AhmarZaidi marked this pull request as ready for review October 22, 2024 14:38
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: AhmarZaidi <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Package] Edit Site /packages/edit-site l10n Localization and translations best practices [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Oct 23, 2024
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhmarZaidi, LGTM

@afercia afercia merged commit 8a7a381 into WordPress:trunk Oct 23, 2024
71 of 73 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 23, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository l10n Localization and translations best practices [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the verb Toggle from the data views 'Toggle details panel'
2 participants