Add new private upload-media package
#66290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Build Tooling
swissspidy
force-pushed
the
add/61447-upload-media-pkg
branch
3 times, most recently
from
ad143dc to
1851a20
Compare
|
Size Change: +4.19 kB (+0.23%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
swissspidy
force-pushed
the
add/61447-upload-media-pkg
branch
from
1851a20 to
b99c449
Compare
swissspidy
force-pushed
the
add/61447-upload-media-pkg
branch
from
b99c449 to
8a57140
Compare
swissspidy
commented
Oct 21, 2024
package.json
Outdated
| @@ -310,7 +311,7 @@ | |||
| "lint:pkg-json": "wp-scripts lint-pkg-json . 'packages/*/package.json'", | |||
| "native": "npm run --prefix packages/react-native-editor", | |||
| "other:changelog": "node ./bin/plugin/cli.js changelog", | |||
| "other:check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios,@ampproject/remapping,human-signals,fb-watchman,walker,chrome-launcher,lighthouse-logger,chromium-edge-launcher\" \"wp-scripts check-licenses --dev\"", | |||
| "other:check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios,@ampproject/remapping,human-signals,fb-watchman,walker,chrome-launcher,lighthouse-logger,chromium-edge-launcher,webpack\" \"wp-scripts check-licenses --dev\"", | |||
There was a problem hiding this comment.
For some reason the Apache-licensed @webassemblyjs/leb128 and @xtuc/long packages, which are dependencies of webpack, were being flagged. No idea why this happened only when working on this PR.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Oct 22, 2024
An oversight. Added now. FWIW this is all coming from https://github.com/swissspidy/media-experiments if anyone wants to see the full context of how everything works together. |
3 tasks
youknowriad
reviewed
Oct 24, 2024
youknowriad
reviewed
Oct 24, 2024
youknowriad
reviewed
Dec 10, 2024
youknowriad
reviewed
Dec 12, 2024
| settings = useMemo( | ||
| () => ( { | ||
| ..._settings, | ||
| mediaUpload: mediaUpload.bind( null, registry ), |
There was a problem hiding this comment.
What's a bit confusing for me here, is that if you use the selector to retrieve the settings, you'll get a different "mediaUpload" than the one you passed as a setting.
There was a problem hiding this comment.
Right, but it's the only way to ensure backward compatibility.
You pass mediaUpload to block-editor settings as the function to upload media to a server.
Other users of block-editor (such as block-library) also use this function to upload media.
The (worse) alternative would be to tell everyone to use addItems() action instead and stop using getSettings().mediaUpload
youknowriad
approved these changes
Dec 13, 2024
7 tasks
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
Co-authored-by: ndiego <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Nick Diego <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Mitchell Austin <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: George Mamadashvili <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
Co-authored-by: ndiego <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Nick Diego <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: Mitchell Austin <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: George Mamadashvili <[email protected]>
afercia
reviewed
Dec 18, 2024
| { "path": "../element" }, | ||
| { "path": "../i18n" }, | ||
| { "path": "../private-apis" }, | ||
| { "path": "../url" } |
There was a problem hiding this comment.
Looks like the indentation with spaces on these lines (they should use tabs) is causing problems for other PRs because the pre-commit hook auto-fixes them so that it results in an unrelated changed file in other PRs. See for example #67433 (comment)
I'll try a quick PR if @swissspidy doesn't beat me to it.
There was a problem hiding this comment.
Good catch. Feel free to.
|
I think this PR seems to cause a critical error when using In fact, errors are occurring in Storybook when using the
Perhaps undefined checks are needed here? |
|
Thanks for pointing that out, looks like a simple fix. I'll make a PR. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a new package for client-side media processing, see #61447 for full context.
It implements a queue-like system for processing media items prior to uploading them to the server. This will be used for things like resizing, cropping, compressing, thumbnail generation, poster generation, subtitle generation, etc.
See also https://github.com/swissspidy/media-experiments/blob/7b91599369f1d3ae412e3e18a4afe2f62257b4dc/docs/technical-overview.md.
This logic has been tested extensively as part of https://github.com/swissspidy/media-experiments, but for this initial PR several features have been removed. They will be reintroduced later in separate PRs to make reviews easier.
The package is private and shall not be published until later on when all of the subsequent PRs are merged.
Why?
Required for a new era of upload handling in Gutenberg
How?
Adds a new package to facilitate integration in the block-editor package
Testing Instructions
CI should be green.
Enable the client-side media processing experiment and upload media to the editor. Everything should still work as usual.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A