Exit zoom out when mode is changed #65975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The concept of modes has changed significantly in WordPress 6.7 and the latest Gutenberg. However, the implementation of the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9a8a2dd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11251484553
|
draganescu
approved these changes
Oct 9, 2024
|
This makes sense to me. Thank you 👍 |
|
Just confirming, this does not interfere with #65702? |
richtabor
changed the title
I think it might yes. However, we need to land this for 6.7 and so it's a priority that we merge this. That PR is not ready to merge and so it will have to take responsibility for adding a condition to work around this. I'll drop a line there. |
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 10, 2024
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: ff8bb81 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65901
What?
Disables zoom out mode when editor mode is changed.
Why?
Currently zoom out doesn't work properly when the editor mode is changed.
NOTE: This is a fix specifically for WP 6.7. Whether the zoom out feature should be treated as a "mode" in itself and where to expose this feature is still a topic for discussion in #65856.
How?
Exit zoom out mode via
resetZoomLevel()when mode is changed.Testing Instructions
Screenshots or screencast
45bc1379fd4289100ce52d8a3fd32dfb.mp4